[Refactor] Stuffs #259
Merged
[Refactor] Stuffs #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 90 90
Lines 6863 6859 -4
=========================================
- Hits 6863 6859 -4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem (Why?)
related to #100
Solution (What/How?)
power_iteration()about 3 ~ 40%Other changes (bug fixes, small refactors)
HAS_GEOTORCHbitsandbytesextra as an optional (will be deprecated in further)Notes
power_iterationbenchmarkWindows 10, GTX 1060 6GB, torch 2.3.0+cu121
random 2048 x 2048 matrix, repeat 100 times
as-is:
1.58sto-be:
1.12s